Skip to content

Commit

Permalink
[web] Fit video tag to wrapper
Browse files Browse the repository at this point in the history
Summary:
This diff solves the video tag fit problem. We could observe small gap between the wrapper and video tag:
{F642219}
Now video tags fit the wrapper:
{F642220}

Linear task: [ENG-4401](https://linear.app/comm/issue/ENG-4401/video-tag-doesnt-fit-the-container-completely)

Test Plan:
The best way to test this is to set `background-color: red` to wrapper tag using built-in inspection tool in your favorite browser and check if video tag covers wrapper completely.

Tested in Firefox, Chrome, and Safari.

Reviewers: bartek, tomek, inka, kamil

Reviewed By: inka

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8525
  • Loading branch information
pklatka committed Aug 2, 2023
1 parent 7492050 commit 00ce9bf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions web/media/media.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ span.multimedia > .multimediaImage > video {
/* in multimedia.react.js */
max-height: 200px;
max-width: 100%;
display: inherit;
}
/* Prevent borders around images without src attribute */
span.multimedia > .multimediaImage > img:not([src]) {
Expand Down

0 comments on commit 00ce9bf

Please sign in to comment.