Skip to content

Commit

Permalink
[lib/native/web] add user edit icon to comm icon pack
Browse files Browse the repository at this point in the history
Summary: Added `user-edit` icon to the comm icons pack. These changes were copy and pasted from Iconmoon. I also added the new icon to our [[ https://www.dropbox.com/home/Comm%20assets/Comm%20Icons%20(Apr%202023) | dropbox ]] for an easy visual reference

Test Plan:
Please see the screenshots below. (The minor visual differences in web/native (the color/size) are just due to different props being used in the `CommIcon` component in web vs native. There is no visual difference with the actual icon)

Native:
{F630487}

Web:
{F630488}

Reviewers: atul, rohan

Reviewed By: rohan

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8467
  • Loading branch information
ginsueddy committed Jul 11, 2023
1 parent 1d7297d commit 2b30b99
Show file tree
Hide file tree
Showing 3 changed files with 61 additions and 37 deletions.
95 changes: 59 additions & 36 deletions lib/shared/comm-icon-config.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,29 @@
{
"IcoMoonType": "selection",
"icons": [
{
"icon": {
"paths": [
"M277.344 374.528c0-71.584 57.536-129.184 128-129.184s128 57.6 128 129.184-57.536 129.184-128 129.184c-70.464 0-128-57.632-128-129.184zM405.344 181.344c-106.272 0-192 86.72-192 193.184s85.728 193.184 192 193.184c106.272 0 192-86.72 192-193.184s-85.728-193.184-192-193.184zM245.344 664.896c-106.272 0-192 86.72-192 193.184v80.608c0 17.664 14.336 32 32 32h640c17.664 0 32-14.336 32-32v-80.608c0-106.464-85.728-193.184-192-193.184h-320zM117.344 858.080c0-71.584 57.536-129.184 128-129.184h320c70.464 0 128 57.632 128 129.184v48.608h-576v-48.608zM918.368 238.656c-4.608-4.608-10.848-7.2-17.344-7.2s-12.736 2.592-17.344 7.2l-261.024 261.024c-4.608 4.608-7.2 10.848-7.2 17.344v80.32c0 13.536 10.976 24.544 24.544 24.544h80.32c6.496 0 12.736-2.592 17.344-7.2l261.024-261.024c4.608-4.608 7.2-10.848 7.2-17.344s-2.592-12.736-7.2-17.344l-80.32-80.32zM898.272 339.040l-22.816-22.816 25.536-25.536 45.632 45.632-25.536 25.536-22.816-22.816zM863.584 373.728l22.816 22.816-176.256 176.256h-45.632v-45.632l176.256-176.256 22.816 22.816z"
],
"attrs": [{}],
"isMulticolor": false,
"isMulticolor2": false,
"grid": 0,
"tags": ["user-edit"]
},
"attrs": [{}],
"properties": {
"order": 406,
"id": 17,
"name": "user-edit",
"prevSize": 32,
"code": 59665
},
"setIdx": 0,
"setId": 2,
"iconIdx": 0
},
{
"icon": {
"paths": [
Expand All @@ -10,20 +33,20 @@
"attrs": [{}, {}],
"isMulticolor": false,
"isMulticolor2": false,
"grid": 0,
"tags": ["user-filled"]
"tags": ["user-filled"],
"grid": 0
},
"attrs": [{}, {}],
"properties": {
"order": 2,
"id": 16,
"id": 0,
"name": "user-filled",
"prevSize": 32,
"code": 59664
},
"setIdx": 0,
"setId": 2,
"iconIdx": 0
"iconIdx": 1
},
{
"icon": {
Expand All @@ -39,14 +62,14 @@
"attrs": [{}],
"properties": {
"order": 405,
"id": 0,
"id": 1,
"name": "pin-outline",
"prevSize": 32,
"code": 59662
},
"setIdx": 0,
"setId": 2,
"iconIdx": 1
"iconIdx": 2
},
{
"icon": {
Expand All @@ -62,14 +85,14 @@
"attrs": [{}],
"properties": {
"order": 402,
"id": 1,
"id": 2,
"name": "unpin-outline",
"prevSize": 32,
"code": 59663
},
"setIdx": 0,
"setId": 2,
"iconIdx": 2
"iconIdx": 3
},
{
"icon": {
Expand All @@ -85,14 +108,14 @@
"attrs": [{}],
"properties": {
"order": 396,
"id": 2,
"id": 3,
"name": "link_plus-outline",
"prevSize": 32,
"code": 59661
},
"setIdx": 0,
"setId": 2,
"iconIdx": 3
"iconIdx": 4
},
{
"icon": {
Expand All @@ -108,14 +131,14 @@
"attrs": [{}],
"properties": {
"order": 393,
"id": 3,
"id": 4,
"name": "edit-filled",
"prevSize": 32,
"code": 59660
},
"setIdx": 0,
"setId": 2,
"iconIdx": 4
"iconIdx": 5
},
{
"icon": {
Expand All @@ -131,14 +154,14 @@
"attrs": [{}],
"properties": {
"order": 380,
"id": 4,
"id": 5,
"name": "pin-mirror",
"prevSize": 32,
"code": 59659
},
"setIdx": 0,
"setId": 2,
"iconIdx": 5
"iconIdx": 6
},
{
"icon": {
Expand All @@ -154,14 +177,14 @@
"attrs": [{}],
"properties": {
"order": 381,
"id": 5,
"id": 6,
"name": "ethereum-outline",
"prevSize": 32,
"code": 59658
},
"setIdx": 0,
"setId": 2,
"iconIdx": 6
"iconIdx": 7
},
{
"icon": {
Expand All @@ -177,14 +200,14 @@
"attrs": [{}],
"properties": {
"order": 382,
"id": 6,
"id": 7,
"name": "pin",
"prevSize": 32,
"code": 59657
},
"setIdx": 0,
"setId": 2,
"iconIdx": 7
"iconIdx": 8
},
{
"icon": {
Expand All @@ -200,14 +223,14 @@
"attrs": [{}],
"properties": {
"order": 383,
"id": 7,
"id": 8,
"name": "unpin",
"prevSize": 32,
"code": 59656
},
"setIdx": 0,
"setId": 2,
"iconIdx": 8
"iconIdx": 9
},
{
"icon": {
Expand All @@ -223,14 +246,14 @@
"attrs": [{}],
"properties": {
"order": 384,
"id": 8,
"id": 9,
"name": "emote-smile-filled",
"prevSize": 32,
"code": 59654
},
"setIdx": 0,
"setId": 2,
"iconIdx": 9
"iconIdx": 10
},
{
"icon": {
Expand All @@ -246,14 +269,14 @@
"attrs": [{}],
"properties": {
"order": 385,
"id": 9,
"id": 10,
"name": "cloud-filled",
"prevSize": 32,
"code": 59648
},
"setIdx": 0,
"setId": 2,
"iconIdx": 10
"iconIdx": 11
},
{
"icon": {
Expand All @@ -272,14 +295,14 @@
"attrs": [{}, {}, {}],
"properties": {
"order": 379,
"id": 10,
"id": 11,
"name": "megaphone",
"prevSize": 32,
"code": 59649
},
"setIdx": 0,
"setId": 2,
"iconIdx": 11
"iconIdx": 12
},
{
"icon": {
Expand All @@ -296,14 +319,14 @@
"attrs": [{}],
"properties": {
"order": 386,
"id": 11,
"id": 12,
"name": "reply-filled",
"prevSize": 32,
"code": 59650
},
"setIdx": 0,
"setId": 2,
"iconIdx": 12
"iconIdx": 13
},
{
"icon": {
Expand All @@ -320,14 +343,14 @@
"attrs": [{}],
"properties": {
"order": 387,
"id": 12,
"id": 13,
"name": "reply",
"prevSize": 32,
"code": 59651
},
"setIdx": 0,
"setId": 2,
"iconIdx": 13
"iconIdx": 14
},
{
"icon": {
Expand All @@ -343,14 +366,14 @@
"attrs": [{}],
"properties": {
"order": 388,
"id": 13,
"id": 14,
"name": "sidebar-filled",
"prevSize": 32,
"code": 59652
},
"setIdx": 0,
"setId": 2,
"iconIdx": 14
"iconIdx": 15
},
{
"icon": {
Expand All @@ -368,14 +391,14 @@
"attrs": [{}, {}, {}],
"properties": {
"order": 390,
"id": 14,
"id": 15,
"name": "sidebar",
"prevSize": 32,
"code": 59653
},
"setIdx": 0,
"setId": 2,
"iconIdx": 15
"iconIdx": 16
},
{
"icon": {
Expand All @@ -393,14 +416,14 @@
"attrs": [{}, {}],
"properties": {
"order": 389,
"id": 15,
"id": 16,
"name": "copy-filled",
"prevSize": 32,
"code": 59655
},
"setIdx": 0,
"setId": 2,
"iconIdx": 16
"iconIdx": 17
}
],
"height": 1024,
Expand Down
Binary file modified native/fonts/CommIcons.ttf
Binary file not shown.
3 changes: 2 additions & 1 deletion web/CommIcon.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ export type CommIcons =
| 'edit-filled'
| 'ethereum-outline'
| 'link_plus-outline'
| 'user-filled';
| 'user-filled'
| 'user-edit';

type CommIconProps = {
+icon: CommIcons,
Expand Down

0 comments on commit 2b30b99

Please sign in to comment.