Skip to content

Commit

Permalink
[lib] modify queryTimeout
Browse files Browse the repository at this point in the history
Summary:
@Ashoat was unable to see usernames on web after logging in following the CSAT launch. he's seen this on native, too. we suspect that the timeout is too short.

more context here: https://linear.app/comm/issue/ENG-9227/ashoat-didnt-see-usernames-on-web-after-logging-in-following-csat

Test Plan: modified identity RPC to sleep for 15 seconds and the previous 10 second timeout was triggered. after changing the timeout duration, I was able to get a response from identity

Reviewers: ashoat

Reviewed By: ashoat

Subscribers: tomek, ashoat

Differential Revision: https://phab.comm.dev/D13277
  • Loading branch information
vdhanan committed Sep 10, 2024
1 parent fe34477 commit 2bf0928
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/components/user-identity-cache.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import sleep from '../utils/sleep.js';

const cacheTimeout = 24 * 60 * 60 * 1000; // one day
const failedQueryCacheTimeout = 5 * 60 * 1000; // five minutes
const queryTimeout = 10 * 1000; // ten seconds
const queryTimeout = 20 * 1000; // twenty seconds

async function throwOnTimeout(identifier: string) {
await sleep(queryTimeout);
Expand Down

0 comments on commit 2bf0928

Please sign in to comment.