-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lib] Use
UPDATE_THREAD_READ_STATUS
update to update the read status
Summary: This update is more convenient because it doesn't override the whole thread, which fixes a bug where the unread status operation sometimes swallows other operations. For the thick threads, this update should also bump a timestamp. https://linear.app/comm/issue/ENG-9343/updating-thread-unread-status-sometimes-swallows-queued-operations Test Plan: 1. Send a message as one user and check if a thread of the other used got marked as unread 2. Send a message as a user and check if a thread doesn't get marked as unread on another device of the same user 3. Check if marking as unread results in a thread being marked as unread on another device of the same user Reviewers: kamil, will Reviewed By: kamil Subscribers: ashoat Differential Revision: https://phab.comm.dev/D13424
- Loading branch information
Showing
3 changed files
with
22 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters