Skip to content

Commit

Permalink
[keyserver] Mark recalculateAllThreadPermissions as deprecated
Browse files Browse the repository at this point in the history
Summary: https://linear.app/comm/issue/ENG-4318/mark-recalculateallthreadpermissions-as-deprecated.

Test Plan: Check if function `DEPRECATED_recalculateAllThreadPermissions` exists in `keyserver/src/updaters/thread-permission-updaters.js`

Reviewers: bartek, tomek, ashoat

Reviewed By: ashoat

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8437
  • Loading branch information
pklatka committed Jul 10, 2023
1 parent e29d0bd commit 50e4497
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions keyserver/src/scripts/add-leave-thread-permissions.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import { threadTypes } from 'lib/types/thread-types-enum.js';

import { endScript } from './utils.js';
import { dbQuery, SQL } from '../database/database.js';
import { recalculateAllThreadPermissions } from '../updaters/thread-permission-updaters.js';
import { DEPRECATED_recalculateAllThreadPermissions } from '../updaters/thread-permission-updaters.js';

async function main() {
try {
await addLeaveThreadPermissions();
await recalculateAllThreadPermissions();
await DEPRECATED_recalculateAllThreadPermissions();
} catch (e) {
console.warn(e);
} finally {
Expand Down
4 changes: 2 additions & 2 deletions keyserver/src/scripts/create-sidebar-permissions.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ import {

import { endScript } from './utils.js';
import { dbQuery, SQL } from '../database/database.js';
import { recalculateAllThreadPermissions } from '../updaters/thread-permission-updaters.js';
import { DEPRECATED_recalculateAllThreadPermissions } from '../updaters/thread-permission-updaters.js';

async function main() {
try {
await createSidebarPermissions();
await recalculateAllThreadPermissions();
await DEPRECATED_recalculateAllThreadPermissions();
} catch (e) {
console.warn(e);
} finally {
Expand Down
5 changes: 3 additions & 2 deletions keyserver/src/updaters/thread-permission-updaters.js
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,8 @@ async function rescindPushNotifsForMemberDeletion(
}
}

async function recalculateAllThreadPermissions() {
// Deprecated - use updateRolesAndPermissionsForAllThreads instead
async function DEPRECATED_recalculateAllThreadPermissions() {
const getAllThreads = SQL`SELECT id FROM threads`;
const [result] = await dbQuery(getAllThreads);

Expand Down Expand Up @@ -1286,6 +1287,6 @@ export {
getChangesetCommitResultForExistingThread,
saveMemberships,
commitMembershipChangeset,
recalculateAllThreadPermissions,
DEPRECATED_recalculateAllThreadPermissions,
updateRolesAndPermissionsForAllThreads,
};

0 comments on commit 50e4497

Please sign in to comment.