[lib] mark messages as sent when there is no messageID in Outbound …

…messages table

Summary: Handle edge-case when the message was sent, but it wasn't updated in the message store (e.g. app was killed), but was already confirmed by the other peer - and when hitting retry there is no message with given ID in the outbound messages table.

Test Plan: Test case described in summary.

Reviewers: tomek

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D13255

lib/tunnelbroker/peer-to-peer-context.js

@@ -78,9 +78,22 @@ async function processOutboundP2PMessages(
 
   const { olmAPI, sqliteAPI } = getConfig();
   await olmAPI.initializeCryptoAccount();
+
+  const sentMessagesMap: { [messageID: string]: boolean } = {};
+
   let messages;
   if (messageIDs) {
     messages = await sqliteAPI.getOutboundP2PMessagesByID(messageIDs);
+    if (messageIDs.length !== messages.length) {
+      const dbMessageIDsSet = new Set<string>(
+        messages.map(message => message.messageID),
+      );
+      for (const messageID of messageIDs) {
+        if (!dbMessageIDsSet.has(messageID)) {
+          sentMessagesMap[messageID] = true;
+        }
+      }
+    }
   } else {
     const allMessages = await sqliteAPI.getAllOutboundP2PMessages();
     messages = allMessages.filter(message => message.supportsAutoRetry);
@@ -95,8 +108,6 @@ async function processOutboundP2PMessages(
     }
   }
 
-  const sentMessagesMap: { [messageID: string]: boolean } = {};
-
   const sendMessageToPeer = async (
     message: OutboundP2PMessage,
   ): Promise<void> => {