Skip to content

Commit

Permalink
[services] Delete unused COMM_TEST_SERVICES
Browse files Browse the repository at this point in the history
Summary:
Part of [[ https://linear.app/comm/issue/ENG-4098/deprecate-remaining-shared-c-services-code | ENG-4098 ]].
We don't use `COMM_TEST_SERVICES` anymore - it was used to unit test C++ services and build test-only version of docker images.

Test Plan: Git grep `COMM_TEST_SERVICES` - no results.

Reviewers: jon, varun

Reviewed By: jon, varun

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8361
  • Loading branch information
barthap committed Jun 30, 2023
1 parent ab08c20 commit bc2586f
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 152 deletions.
1 change: 0 additions & 1 deletion services/.env
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ COMM_SERVICES_PORT_BACKUP=50052
COMM_SERVICES_PORT_BLOB=50053
COMM_SERVICES_PORT_IDENTITY=50054
COMM_SERVICES_PORT_FEATURE_FLAGS=50055
COMM_TEST_SERVICES=0
3 changes: 1 addition & 2 deletions services/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ services:
dockerfile: services/backup/Dockerfile
context: ../
args:
- COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
- COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
- LOCALSTACK_URL=http://localstack:4566
- BLOB_SERVICE_URL=http://blob-server:50051
Expand All @@ -42,7 +41,6 @@ services:
dockerfile: services/blob/Dockerfile
context: ../
args:
- COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
- COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX}
image: commapp/blob-server:0.1
ports:
Expand All @@ -60,6 +58,7 @@ services:
image: commapp/identity-server:0.1
ports:
- '${COMM_SERVICES_PORT_IDENTITY}:50054'
# feature-flags
feature-flags-server:
depends_on:
- localstack
Expand Down
1 change: 0 additions & 1 deletion services/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"run-feature-flags-service": "./scripts/run_server_image.sh feature-flags",
"run-feature-flags-service-in-sandbox": "COMM_SERVICES_SANDBOX=1 ./scripts/run_server_image.sh feature-flags",
"run-all-services": "./scripts/run_all_services.sh",
"run-unit-tests": "./scripts/run_unit_tests.sh",
"run-integration-tests": "./scripts/run_integration_tests.sh",
"run-performance-tests": "./scripts/run_performance_tests.sh",
"run-all-services-in-sandbox": "COMM_SERVICES_SANDBOX=1 ./scripts/run_all_services.sh",
Expand Down
1 change: 0 additions & 1 deletion services/scripts/run_integration_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

set -e

export COMM_TEST_SERVICES=1
export COMM_SERVICES_SANDBOX=1

SERVICES=$(./scripts/list_services.sh)
Expand Down
43 changes: 0 additions & 43 deletions services/scripts/run_unit_tests.sh

This file was deleted.

104 changes: 0 additions & 104 deletions services/terraform/dynamodb-test.tf

This file was deleted.

0 comments on commit bc2586f

Please sign in to comment.