Skip to content

Commit

Permalink
[GH Actions] Add gradle.jvmargs args to ./gradlew bundleRelease
Browse files Browse the repository at this point in the history
Summary:
This is kind of a longshot, but noticed that the disk usage issue was accompanied by a stackoverflow issue during some sort of final signing step. This issue doesn't replicate on my fork because I didn't include the keys necessary for signing.

I also noticed that the disk usage issue specified that the error occured when trying to write to some sort of build log file.

Maybe there's a stack overflow issue that's causing a lot of logging that's eating up disk space? It's a stretch, but figure it doesn't hurt to bump `gradle.jvmargs` to possibly reduce chance of stack overflow?

Test Plan: Land and see what happens.

Reviewers: ashoat, ginsu, marcin, tomek, jon

Reviewed By: ashoat

Differential Revision: https://phab.comm.dev/D8718
  • Loading branch information
atulsmadhugiri committed Aug 4, 2023
1 parent 4c7f91e commit d1ea1b4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/android_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
working-directory: ./native/android
env:
ANDROID_SIGNING_PASSWORD: ${{secrets.ANDROID_SIGNING_PASSWORD}}
run: ./gradlew bundleRelease
run: ./gradlew bundleRelease "-Dorg.gradle.jvmargs=-Xmx6g -XX:MaxMetaspaceSize=6g"

- name: Disk Usage
run: df -h
2 changes: 1 addition & 1 deletion .github/workflows/android_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
working-directory: ./native/android
env:
ANDROID_SIGNING_PASSWORD: ${{secrets.ANDROID_SIGNING_PASSWORD}}
run: ./gradlew bundleRelease
run: ./gradlew bundleRelease "-Dorg.gradle.jvmargs=-Xmx6g -XX:MaxMetaspaceSize=6g"

- name: Save PLAY_STORE_PUBLISHING_KEY to file
working-directory: ./native/android
Expand Down

0 comments on commit d1ea1b4

Please sign in to comment.