Skip to content

Commit

Permalink
[native] default selectMultipleEmojis to false for emoji keyboard
Browse files Browse the repository at this point in the history
Summary: As I was working on the inline engagement redesign, I noticed some strange behavior with the emoji keyboard showing the already selected emoji when selecting a new emoji. This diff fixes that issue

Test Plan:
Emoji keyboard now works as expected

{F608305}

Reviewers: atul, kamil

Reviewed By: kamil

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8319
  • Loading branch information
ginsueddy committed Jul 7, 2023
1 parent 6de5244 commit d738d92
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions native/chat/multimedia-message-tooltip-button.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ function MultimediaMessageTooltipButton(props: Props): React.Node {
emojiKeyboardOpen={emojiPickerOpen}
onEmojiKeyboardClose={dismissTooltip}
alreadySelectedEmojis={alreadySelectedEmojis}
selectMultipleEmojis
/>
</>
);
Expand Down
1 change: 1 addition & 0 deletions native/chat/robotext-message-tooltip-button.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ function RobotextMessageTooltipButton(props: Props): React.Node {
emojiKeyboardOpen={emojiPickerOpen}
onEmojiKeyboardClose={dismissTooltip}
alreadySelectedEmojis={alreadySelectedEmojis}
selectMultipleEmojis
/>
</>
);
Expand Down
1 change: 1 addition & 0 deletions native/chat/text-message-tooltip-button.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ function TextMessageTooltipButton(props: Props): React.Node {
emojiKeyboardOpen={emojiPickerOpen}
onEmojiKeyboardClose={dismissTooltip}
alreadySelectedEmojis={alreadySelectedEmojis}
selectMultipleEmojis
/>
</MessageListContextProvider>
);
Expand Down
2 changes: 1 addition & 1 deletion native/components/emoji-keyboard.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function EmojiKeyboard(props: Props): React.Node {
onEmojiSelected,
emojiKeyboardOpen,
onEmojiKeyboardClose,
selectMultipleEmojis,
selectMultipleEmojis = false,
alreadySelectedEmojis,
} = props;

Expand Down

0 comments on commit d738d92

Please sign in to comment.