-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ansible modules, task level parameters and commands #82
base: master
Are you sure you want to change the base?
Conversation
Cool, thanks for the PR! I'll try to give it a spin soon. Screen real estate is definitely a problem. One solution we've talked about is asking players to pick a language category before they play. We opted out of that in the current version because we wanted to minimize the number of steps before play begins (there are already a lot of text instructions to digest). But I think we need to bite that bullet so that more language categories can be added. Like this one! |
Can't wait to play this. |
Hm, had another idea for how to handle having too many languages. We could un-feature one of the current languages and put Ansible in its place. My vote would be for Python since in my experience it's the least used (FTR I love python). We would leave it in the codebase, but simply deactivate it until the "choose your language" feature is implemented. How does that sound? |
I am not opposed to featuring Ansible, but I do marketing for Ansible :) I am fine with that as a temporary fix. Do you want me to fix the PR, or just merge this and add that separately? I am also thinking about what you said earlier->
|
Oooh, that's what I'm talking about. I like the persona idea very much. For this PR, I think de-featuring Python in favor of Ansible is the best move. Then, later, we can revive Python to its current and soon-to-be-former glory. |
@IPvSean I finally gave this a try. Sorry for the delay. Could you add some ansible commands to the |
Does it matter which ones? I thought commonCmds were cmds that overlapped
with other types (e.g. Python)
…On Thu, Aug 15, 2019 at 1:36 PM Michael Clayton ***@***.***> wrote:
@IPvSean <https://github.com/IPvSean> I *finally* gave this a try. Sorry
for the delay. Could you add some ansible commands to the commonCmds
array? Without that, no bonus commands can be assigned to ansible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#82?email_source=notifications&email_token=ABR4DUAXLKFHXPVWPHFTAADQEWHXXA5CNFSM4HYMWJM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MPFFI#issuecomment-521728661>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABR4DUBINGAE2GVQYFNIMITQEWHXXANCNFSM4HYMWJMQ>
.
|
Nah, It's entirely up to you what goes into By the way, although I haven't merged this branch yet, I did include it in the clh-bash build that's currently on its way to VMworld and Open Source Summit! Players are both confs will get to play with ansible commands. 🥂 To make it work I took my best guess at commonCmds: [
"ansible",
"acl",
"apk",
"apt",
"at",
"assert",
"copy",
"cron",
"debug",
"dnf",
"loop",
"name",
"when",
"yum",
"user",
"setup"
], |
hey @mwcz sorry for delay, getting carpel tunnel surgery, so much fun :) does this look good now? |
is this good @mwcz |
Hi guys, just checking the repo after having it sit on my bookmarks for a while since I heard the podcast. I have a suggestion on this issue:
Hope this helps! :) |
Thanks @davidjonas! You seem to have made your comment in response to a pull request adding Ansible commands to the game. Can you open a new issue with your comments instead? I'd love to discuss them, just not on this PR. :) |
Summary of PR
finally got this working and not crashing on my own laptop, suggest testing on my fork before merging. In the future I will try to auto-generate all the directives rather than have a static file containing them all.
Development Environment
works on my macOS 10.14.5 in Chrome Version 74.0.3729.169 (Official Build) (64-bit)
Issues