-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the regex for the PowerShell parser #33
Conversation
@michael-hawker Could you please do a code review? Thanks! |
Gently ping. @michael-hawker @azchohfi, can you please review this PR? Thanks! |
Sorry, I was away. @daxian-dbw do you have a before/after picture of the changes on a PowerShell file? Otherwise, appears good! |
@michael-hawker No worries! Before the change After the change |
@michael-hawker gentle ping :) Can you please review again? The pictures were added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case sensitivity for keywords was fixed, Commands and Parameters are now highlighted, and several more inbox attributes are now supported (case insensitive). No obvious issues. Approved 👍
@Arlodotexe and @michael-hawker, thanks for the review! |
Update the regex for the PowerShell parser:
|
and the array literal operator,
;pwsh
as an alias for thePowerShell
language;