Replace BaseTheme with AppStyles

[HobDev]

Description of Change

As AppThemeBinding is available now I removed the old way of supporting Themes. Instead I use AddAppThemeBinding in the Styles. The changes are in the Sample app only.

Linked Issues

• Fixes #

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: Added an initial page on theming MicrosoftDocs/CommunityToolkit#189

Additional information

[brminnick]

Thanks @HobDev! I really like this approach!

Could you also submit a PR to our docs, adding this? I think a lot of developers would find this really helpful too!

It doesn't look like we have any documentation on theming, so I can see two ways you could approach this problem:

• Create a new doc page, something like /docs/maui/markup/theming.md
  • I think this would be best to help devs specifically looking for Light Theme / Dark Theme help
• Add to the existing styles.md doc docs/maui/markup/extensions/style.md
  • Add a ## Theming section here
  • Putting it in the existing Style API docs may bury the info and be tough for devs to find, though

Once you have a PR open for the docs, I'll merge this PR 🙌

(I've added the pending documentation This feature requires documentation and do not merge Do not merge this PR labels to remind me not to accidentally merge this until the docs are done)

[brminnick]

Thanks again @HobDev! Just a few recommendations to keep the color constants (I would put them in AppStyles.cs)

[bijington]

I am happy to provide the docs for how to style an application given I should have done so with the previous PR.

[HobDev]

I am happy to provide the docs for how to style an application given I should have done so with the previous PR.

@bijington Thank you for the help. So I need not work on the docs as you are going to write it.

[HobDev]

@brminnick Thank you for the review. I made all colors static readonly in the latest commit. The Colors which are used in Dark Mode have Dark at the end of their name. I am not sure whether this naming is correct. Please let me know if further improvements are required.

[bijington]

Thanks @HobDev! I really like this approach!

Could you also submit a PR to our docs, adding this? I think a lot of developers would find this really helpful too!

It doesn't look like we have any documentation on theming, so I can see two ways you could approach this problem:

• Create a new doc page, something like /docs/maui/markup/theming.md

  • I think this would be best to help devs specifically looking for Light Theme / Dark Theme help

• Add to the existing styles.md doc docs/maui/markup/extensions/style.md

  • Add a ## Theming section here
  • Putting it in the existing Style API docs may bury the info and be tough for devs to find, though

Once you have a PR open for the docs, I'll merge this PR 🙌

(I've added the pending documentation This feature requires documentation and do not merge Do not merge this PR labels to remind me not to accidentally merge this until the docs are done)

I have added a PR at MicrosoftDocs/CommunityToolkit#189 strangely I can't seem to assign you as a reviewer @brminnick

[brminnick]

Thanks @HobDev!!

And thank you @bijington for folding this into the docs! It'll be super helpful for devs in the future 💯