Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GesturesExtensions.TypedBindings.cs #192

Merged
merged 10 commits into from
May 18, 2023

Conversation

brminnick
Copy link
Collaborator

@brminnick brminnick commented Feb 26, 2023

Description of Change

This PR implements Typed Bindings for GestureRecognizers

Linked Issues

PR Checklist

@brminnick brminnick added do not merge Do not merge this PR pending documentation This feature requires documentation labels Feb 26, 2023
@brminnick brminnick assigned bijington and brminnick and unassigned bijington Mar 5, 2023
@brminnick brminnick requested a review from bijington March 5, 2023 02:55
@brminnick brminnick marked this pull request as ready for review March 5, 2023 02:55
Copy link
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brminnick it looks good to me. Did we want to include the usage in the sample application in some way? I can't think of a useful example right now though.

Do we also need a docs update?

@brminnick
Copy link
Collaborator Author

Thanks Shaun! We currently don't use GestureRecognizers in the sample app, but I'll find a way to squeeze it in 👍

Yup! We do need a docs update. Any chance you're available to help? The Unit Tests added in this PR should demonstrate usage of the new APIs so that you don't have to wait on me to update the Sample App.

@bijington
Copy link
Contributor

Thanks Shaun! We currently don't use GestureRecognizers in the sample app, but I'll find a way to squeeze it in 👍

Yup! We do need a docs update. Any chance you're available to help? The Unit Tests added in this PR should demonstrate usage of the new APIs so that you don't have to wait on me to update the Sample App.

Yep I can take a look at the docs

@brminnick
Copy link
Collaborator Author

Hey @bijington! Any chance you've got the docs PR opened?

I'd be great to merge this and publish a new release this week!

@bijington
Copy link
Contributor

Hey @bijington! Any chance you've got the docs PR opened?

I'd be great to merge this and publish a new release this week!

Sorry it completely slipped my mind. I'm heading away for 2 weeks from tomorrow too so I won't be able to get it done before I return.

@ghost ghost added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels May 4, 2023
@brminnick brminnick removed do not merge Do not merge this PR stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented pending documentation This feature requires documentation labels May 18, 2023
@brminnick brminnick enabled auto-merge (squash) May 18, 2023 18:00
@brminnick brminnick merged commit 287460e into main May 18, 2023
@brminnick brminnick deleted the Add-Typed-Binding-Gesture-Extensions branch May 18, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add TypedBindings to GesturesExtensions
2 participants