Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FileSaver doesn't handle non-seekable streams #1078

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Fix FileSaver doesn't handle non-seekable streams #1078

merged 2 commits into from
Mar 9, 2023

Conversation

VladislavAntonyuk
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk commented Mar 9, 2023 •
edited
Loading

Description of Change

Linked Issues

PR Checklist

Additional information

@VladislavAntonyuk VladislavAntonyuk requested a review from a team March 9, 2023 15:00
@VladislavAntonyuk VladislavAntonyuk self-assigned this Mar 9, 2023
@VladislavAntonyuk VladislavAntonyuk enabled auto-merge (squash) March 9, 2023 15:01
bijington
bijington approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @VladislavAntonyuk

@bijington
Copy link
Contributor

Great quick fix @VladislavAntonyuk sorry I wasn't at a computer otherwise I would have done more than just the suggestion

@VladislavAntonyuk
Copy link
Collaborator Author

Don't worry @bijington , thank you for the super fast review.

@pictos pictos closed this Mar 9, 2023
auto-merge was automatically disabled March 9, 2023 15:22

Pull request was closed

@pictos pictos reopened this Mar 9, 2023
@pictos pictos enabled auto-merge (squash) March 9, 2023 15:23
@pictos
Copy link
Member

pictos commented Mar 9, 2023

The second time I see "Operation was canceled" on the builds log. Should we investigate that?

@pictos pictos merged commit c72bc38 into main Mar 9, 2023
@pictos pictos deleted the 1077-fix-not-seek-stream-saving branch March 9, 2023 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bijington bijington bijington approved these changes

Assignees

@VladislavAntonyuk VladislavAntonyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] FileSaver doesn't handle non-seekable streams
3 participants
@VladislavAntonyuk @bijington @pictos