Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Fix Directory.Build.targets for macOS #1081

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

brminnick
Copy link
Collaborator

@brminnick brminnick commented Mar 10, 2023

Description of Change

This PR fixes an error in Directory.Build.targets that prevented *.macos.cs files from being compiled.

Additional Information

This bug was found when reviewing #1064 which requires different implementations for iOS + macOS.

This PR also changes the incorrect filename for MauiSemanticOrderView:
MauiSemanticOrderView.ios.cs -> MauiSemanticOrderView.macios.cs

This PR also precludes prerelease versions of .NET by adding "allowPrerelease": false to global.json. This ensures that developers with .NET 8 previews installed do not experience build conflicts.

@brminnick brminnick mentioned this pull request Mar 10, 2023
6 tasks
@brminnick brminnick enabled auto-merge (squash) March 10, 2023 01:42
@brminnick brminnick merged commit c2f9b85 into main Mar 10, 2023
@brminnick brminnick deleted the Fix-`Directory.Build.targets` branch March 10, 2023 02:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants