Add TouchBehavior

[Axemasta]

This is a rebase of the touch-effect branch, back ontop of main.

The rebase wasn't pretty and there were lots of conflicts, I sided with main in every conflicted file but there were still some issues that had to be resolved by hand. Where any file was broken by the rebase, I have copied the code from main in to replace the contents.

[bijington]

@Axemasta thanks for updating this PR. What action do you need now? Do you need a maintainer to review the current changes? Looking on my phone I see changes to popup related bits which might not be intended?

[Axemasta]

The outstanding work as I am aware is:

• Fix input transparency on iOS (Code is complete and I have a branch with the fix on my fork)
• Fix unit tests (a couple are failing)
• Update sample app & make the touch behavior sample inline with other MCT sample pages

The next steps are testing and ensuring it works and is ready to merge!

I'm not sure what to do about this branch since its a rebase branch, do we abandon the old touch effect branch and merge this one (when ready)? If we decide to use the old branch, I can't rebase since i dont have push permissions and i'm unsure of how I can rebase it without doing a force push.

[bijington]

What's the least amount of effort for you? I can rebase and force push if you need?

[brminnick]

You don't need to fret about rebasing, @Axemasta, we have branch protection rules in place that will take care of that automatically for you.

To keep this PR scoped to the new TouchBevahior control, please remove the all of edits to files that are unrelated to the new TouchBehavior:

• samples/CommunityToolkit.Maui.Sample/App.xaml.cs
• src/CommunityToolkit.Maui.Core/Views/Alert/AlertView.macios.cs
• src/CommunityToolkit.Maui.Core/Views/DrawingView/PlatformView/MauiDrawingView.android.cs
• src/CommunityToolkit.Maui.Core/Views/DrawingView/PlatformView/MauiDrawingView.windows.cs
• src/CommunityToolkit.Maui.Core/Views/DrawingView/PlatformView/MauiDrawingView.windows.cs
• src/CommunityToolkit.Maui.MediaElement/CommunityToolkit.Maui.MediaElement.csproj
• src/CommunityToolkit.Maui/Behaviors/PlatformBehaviors/Touch/SafeFireAndForgotExtensions.cs
• src/CommunityToolkit.Maui/CommunityToolkit.Maui.csproj

[Axemasta]

@brminnick I have addressed all but two of these files in my latest commit, the files not address are:

• samples/CommunityToolkit.Maui.Sample/App.xaml.cs, this will be reverted when i add the demo page to the sample
• src/CommunityToolkit.Maui/Behaviors/PlatformBehaviors/Touch/SafeFireAndForgotExtensions.cs, this is part of the touch behavior feature

[Axemasta]

I mentioned this in the discord yesterday, after updating the sample app to use a viewmodel I discovered the TouchBehavior will not update its binding context & the commands (or any bindings) will not work. This is due to the behavior being a PlatformBehavior which does not set a binding context.

I discovered this from the following sources:

• Binding does not work for Platform dependent Behaviors
• Binding does not work for Platform dependent Behaviors Maui - #11729
• Binding does not work for Platform dependent Behaviors MCt - #795

For the time being I have opted to set the binding context of the platform behavior so that the sample functions in the intended way. My question here is will this cause issues for consumers of the behavior? Is there any special handling we will need to do to ensure there aren't issues or would we be better reverting to the old api design, which uses attached properties to achieve the behavior?

@pictos what do you think about this issue?

[pictos]

@Axemasta Yeah, as you can see on #795 it's this way by design (as I mentioned in the discussion).

For the time being I have opted to set the binding context of the platform behavior so that the sample functions in the intended way

The user can set the BindingContext itself, and use the normal Binding expression. And I believe that we should align our implementation with the general recommendation, that's to set BindingContext on behaviors.

[bijington]

And I believe that we should align our implementation with the general recommendation, that's to set BindingContext on behaviors.

Does this mean the toolkit should set the BindingContext in the behaviors? Or we apply it to our samples?

[pictos]

And I believe that we should align our implementation with the general recommendation, that's to set BindingContext on behaviors.

Does this mean the toolkit should set the BindingContext in the behaviors? Or we apply it to our samples?

The toolkit shouldn't apply the BindingContext to its behaviors. The reason Behaviors don't set the BindingContext is because they are meant to be reusable (for example you set a behavior on a style). With that, the user should decide if he wants to set the BindingContext or use the RelativeSource to set the bindings.

[bijington]

Thanks for the detail. Adding a behavior to a Style when you have properties like Commands that will need to be bound or assigned sounds like a dangerous thing to be able to do.

I'm not criticizing anything here, just stating it feels a bit dangerous to allow it

[Axemasta]

I'm not criticizing anything here, just stating it feels a bit dangerous to allow it

I agree, previously you couldn't do this because it was using an attached effect. The docs are going to have to be quite clear here that here is a specific way you setup binding & you definitely shouldn't apply to a style.

People can still abuse it at their own risk, but the documented way should work fine!

[brminnick]

The docs are going to have to be quite clear

The .NET Maui docs on Behaviors are very explicit that behaviors do not inherit the BindingContext of their parent: https://learn.microsoft.com/en-us/dotnet/maui/fundamentals/behaviors?view=net-maui-8.0#create-a-net-maui-behavior

[bijington]

Oh good spot! We should link to that on all behavior pages

[bijington]

@Axemasta do you think it's fairly safe for me to get started on the docs PR for this?

[Axemasta]

@Axemasta do you think it's fairly safe for me to get started on the docs PR for this?

Yes I think so, the hover feature requires implementing and I'm starting to look at that. Api wise everything is there and aside from hover it behaves how it did in forms

[Axemasta]

Current status of the pr, I have fixed hover which is now working on both platforms. Tests immediately all went green as a bonus (minus 1 test that had the wrong default plugged into it).

All that remains dev wise is to fix the issue i'm seeing on android devices where a child view becomes invisible if the parent has the effect applied. I've narrowed it down to UseNativeAnimation being the culprit, when we don't apply a ripple view the components render fine and are visible, its only when applying the ripple that the child view gets made invisible. I need to debug further to find the cause.

[AlleSchonWeg]

@Axemasta thanks for bringing this to the toolkit.
The old XF Toucheffect (NativeAnimation) never works for me when the effect was attached on a layout in a list/cv or scrollview. The effect was executed even the user just want to scroll the items.
On iOS i used XamEffects: https://github.com/mrxten/XamEffects/. But this not works in android. I created my own version for android: mrxten/XamEffects#52 (comment)
Perhaps it helps you.

[Axemasta]

Perhaps it helps you.

Thanks its good to know it wasn't working properly in the XCT. I checked my port and the iOS native animations work but the android ones don't show so I've clearly ported the bug 😂. Currently the ripple animation is actually playing on Android, the issue is that the ripple view swallows any child views therefore causing the ui not to render correctly.

I've actually found the root cause and I'm working on shipping a fix to position the ripple view behind any child views so the order of views it correct.

The XamEffect library looks really cool, I've used the syncfusion ripple in the past and love how slick it makes your controls look. Its a small addition that makes a big difference to the look & feel of the app 😌

[Axemasta]

Ok i've been able to fix the issue i was seeing on android with nested view, I've simply removed the code that brings the ripple view to the front, it was causing the problems.

I can verify expected appearances work:

And more complicated nested layouts also work properly:

This also works for a single view that has no nested views :)

I believe this PR is feature complete now and is ready for a proper review!

[bijington]

I hate to suggest big changes but is it a silly idea to suggest a rename to InteractionBehavior given this does a lot more than just touch based interactions?

[bijington]

Wow! There is a LOT to this TouchBehavior API! I know this came from XCT and @Axemasta you have put in a lot of effort to bring it to the toolkit! I am just trying to comprehend how I can get some docs written. I think I will take the samples page and build on from there.

These question(s) are purely to open a conversation:

• do we know why we have properties like NormalBackgroundImageSource that only apply when the behavior is attached to an Image? I've been trying to think on how it might be possible (and failing) to only expose these properties when the behavior is attached to an Image element.

Re-review requested

[brminnick]

Update Unit Tests

[MitchBomcanhao]

fyi I've just tried the 99.0.0-preview1678 nightly build (the first where TouchBehavior seems to appear in), and it seems to make my windows app crash on launch with an unspecified error and on android nothing really happens when adding a touchbehaviour to a control.

[pictos]

@MitchBomcanhao please open an issue with a sample project that reproduces the error

[MitchBomcanhao]

@pictos to get the windows app failing on launch, Just get a blank new app, add that nightly build to the project, and launch the app. it'll fail with the error shown below. It'll take me longer to figure out how to make a sample project added to github (which is a requirement to open an issue) than it will for you to try this.

Unspecified error

   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0(Int32 hr)
   at WinRT.ExceptionHelpers.ThrowExceptionForHR(Int32 hr)
   at ABI.Microsoft.Windows.AppNotifications.IAppNotificationManagerMethods.Register(IObjectReference _obj)
   at Microsoft.Windows.AppNotifications.AppNotificationManager.Register()
   at CommunityToolkit.Maui.AppBuilderExtensions.<>c.<UseMauiCommunityToolkit>b__0_3(Application _, LaunchActivatedEventArgs _)
   at Microsoft.Maui.MauiWinUIApplication.<>c__DisplayClass1_0.<OnLaunched>b__3(OnLaunched del)
   at Microsoft.Maui.LifecycleEvents.LifecycleEventServiceExtensions.InvokeLifecycleEvents[TDelegate](IServiceProvider services, Action`1 action)
   at Microsoft.Maui.MauiWinUIApplication.OnLaunched(LaunchActivatedEventArgs args)
   at Microsoft.UI.Xaml.Application.Microsoft.UI.Xaml.IApplicationOverrides.OnLaunched(LaunchActivatedEventArgs args)
   at ABI.Microsoft.UI.Xaml.IApplicationOverrides.Do_Abi_OnLaunched_0(IntPtr thisPtr, IntPtr args)

[brminnick]

I confirmed that TouchBehavior works as expected in CommunityToolkit.Maui.Sample on both Android + Windows

Android	Windows

@MitchBomcanhao Could you open an Issue and provide a reproduction sample today? We are planning to release TouchBehavior in CommunityToolkit.Maui v8.0.0 tomorrow (Friday 28 March).

[MitchBomcanhao]

@brminnick I will not be able to get that done today as I'm about at the end of the working day... (and it is a long weekend in the UK). I came across this issue on two different projects (one a production app and another a brand new blank app where there's no other code modified other than updating maui, adding the toolkit and initialising it in mauiprogram.cs. perhaps there's some OS level issue where you might be running different windows versions? fyi I'm on windows 10 build 19045.4170 and VS 17.9.4 - that's pretty much all I got for you right now :/

[brminnick]

I confirm the nightly NuGet Package of main crashes on startup on Windows. It is a regression from this PR: #1658

I also confirm the nightly NuGet Package of main works as expected on Android.

[ryan-autonomousutilities]

Are there any examples of using a CommandParameter for one of these touch events (I'm trying to use the new LongTap)? I can't find one in the samples, and no matter what I try, null gets passed to the command. I just need an example to see the proper syntax.

[brminnick]

You'll need to manually set TouchBehavior.BindingConext.

Here's more information: https://stackoverflow.com/questions/78245724/both-touchbehavior-commandparameter-and-touchbehavior-longpresscommandparamet