Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix System.Math.ThrowMinMaxException #2072

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Fix System.Math.ThrowMinMaxException #2072

merged 11 commits into from
Sep 4, 2024

Conversation

BaY1251
Copy link
Contributor

@BaY1251 BaY1251 commented Jul 30, 2024 •
edited
Loading

Description of Change

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@pictos
Copy link
Member

pictos commented Aug 1, 2024

@BaY1251 can you please add a sample where we can reproduce the error? You didn't provide a reproduction on opened issue. That way we can validate the error, see if your PR will fix the error and avoid regressions. Thanks in advance

BaY1251
BaY1251 commented Sep 2, 2024
View reviewed changes
Copy link
Contributor Author

@BaY1251 BaY1251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept suggestion

@VladislavAntonyuk
Copy link
Collaborator

Thank you @BaY1251 . Please also update the sample app to include the scenario you describe in the issue.
All other things look good to me.

bijington
bijington approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @BaY1251

@bijington bijington enabled auto-merge (squash) September 4, 2024 19:28
@bijington bijington merged commit 24aca96 into CommunityToolkit:main Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladislavAntonyuk VladislavAntonyuk VladislavAntonyuk left review comments

@bijington bijington bijington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@BaY1251 @pictos @VladislavAntonyuk @bijington