Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ColorToStringConverter.shared.cs #2093

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

cl2raul66
Copy link
Contributor

Add ColorToHexArgbStringConverter

This PR adds a new converter, ColorToHexArgbStringConverter, which allows you to convert between Color objects and hex strings in ARGB format.

Add ColorToHexArgbStringConverter
@cl2raul66
Copy link
Contributor Author

@dotnet-policy-service agree

@brminnick
Copy link
Collaborator

brminnick commented Aug 6, 2024

Thanks! Before we can merge this, we need two more things:

@cl2raul66
Copy link
Contributor Author

  • Add Unit Tests

I don't know how to do that step

@brminnick brminnick added the help wanted This proposal has been approved and is ready to be implemented label Aug 19, 2024
@Jake-Derrick
Copy link
Contributor

@cl2raul66, I created a PR to add unit tests to this branch. Let me know what you think!

@brminnick
Copy link
Collaborator

Thanks @Jake-Derrick!

@cl2raul66 - could you please merge it? I believe you're the only one who has the capability to accept + merge his PR.

@brminnick brminnick removed the help wanted This proposal has been approved and is ready to be implemented label Sep 10, 2024
@brminnick brminnick added pending documentation This feature requires documentation approved This Proposal has been approved and is ready to be added to the Toolkit labels Sep 10, 2024
@brminnick
Copy link
Collaborator

Thanks! I approve this PR.

Once you've opened a PR on our Docs Repo providing documentation of the new feature, we can merge this.

@bijington
Copy link
Contributor

Docs PR is in, sorry we missed this: MicrosoftDocs/CommunityToolkit#451

@bijington bijington removed the pending documentation This feature requires documentation label Sep 10, 2024
@bijington bijington merged commit 9cdbec5 into CommunityToolkit:main Sep 10, 2024
8 checks passed
@cl2raul66 cl2raul66 deleted the patch-2 branch September 11, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This Proposal has been approved and is ready to be added to the Toolkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants