Change the calling conditions of Popup's Dismiss method on Android

[cat0363]

This PR resolves the issue where an exception occurs when the Popup's Close method is called when the Activity that displays the Popup has already been destroyed.

Description of Change

This issue occurs when the Popup's Dismiss method is called when the Activity that displays the Popup has already been discarded.

[mono-rt] [ERROR] FATAL UNHANDLED EXCEPTION: Java.Lang.IllegalArgumentException: View=DecorView@357f8b6[MainActivity] not attached to window manager

If the Activity that displays the Popup has already been disposed of, I will modify it so that the Dismiss method of the Popup is not called.

[src\CommunityToolkit.Maui.Core\Handlers\Popup\PopUpHandler.android.cs]

	public static void MapOnClosed(PopupHandler handler, IPopup view, object? result)
	{
		var popup = handler.PlatformView;

		if (!popup.Context.GetActivity().IsDestroyed())
		{
			if (popup.IsShowing)
			{
				popup.Dismiss();
			}
		}

		view.HandlerCompleteTCS.TrySetResult();

		handler.DisconnectHandler(popup);
	}

Linked Issues

• Fixes [BUG] [ANDROID] Popup kills application when trying to close after Activity.OnDestroy #2135

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Below are the verification results.
I tested the verification code for Issue #2135 by setting the time to close the Popup to 5 seconds.

Android.Emulator.-.pixel_2_-_api_30_5554.2024-08-29.10-36-57.mp4

Even if the Popup's Close method is called 5 seconds after the Popup is displayed, no exception is thrown.
When you return from standby, you will see that the Activity has been newly started.

The following is the verification result when waiting 5 seconds without setting it to standby.

Android.Emulator.-.pixel_2_-_api_30_5554.2024-08-29.10-41-16.mp4

You can see that the popup is closed as intended.

[bijington]

Thank you @cat0363

[bijington]

I assume this is ready to merge?

[cat0363]

When I checked, the following unit test failed.

CommunityToolkit.Maui.UnitTests.Views.PopupTests.PopupDismissedByTappingOutsideOfPopup

It is unclear whether the unit test imitates Activity like the Android emulator.

@bijington , In this unit test, does the activity exist?
If the activity does not exist, the Popup's Dismiss method will not be called, so the unit test is expected to fail with a timeout.

[cat0363]

@bijington , I mistakenly thought that the error was occurring in the unit test on the Android side.
This seems to be occurring on the macOS side, which is unrelated to this change.

CommunityToolkit.Maui.UnitTests.Views.PopupTests.PopupDismissedByTappingOutsideOfPopup

[bijington]

@cat0363 thansk for the explanation. I'm not sure why it would be failing on macOS and not windows. I'll try and take a look this week 👍

[bijington]

The test passes locally on my mac