Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test sdk match the test runner on the Mac build agent #2200

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

bijington
Copy link
Contributor

Description of Change

Linked Issues

  • Fixes #

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@brminnick
Copy link
Collaborator

Interesting! Do you think this may be the cause of why our Unit Tests randomly fail in the CI/CD pipeline?

@bijington
Copy link
Contributor Author

Interesting! Do you think this may be the cause of why our Unit Tests randomly fail in the CI/CD pipeline?

It's probably nothing but I noticed that the macOS agent is running:

Microsoft (R) Test Execution Command Line Tool Version 17.10.0 (x64)

@bijington bijington changed the title Make test sdk match the test runner on the windows build agent Make test sdk match the test runner on the Mac build agent Sep 11, 2024
@bijington
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good!

@bijington
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bijington
Copy link
Contributor Author

3 successful builds in a row. Fingers crossed it stays that way

@bijington bijington merged commit 713b4f0 into main Sep 11, 2024
8 checks passed
@bijington bijington deleted the feature/sl-play-around-with-unit-tests branch September 11, 2024 21:06
@bijington
Copy link
Contributor Author

Looks like it wasn't this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants