Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: AvatarView clipping on Android isn't applied correctly #668

Merged
merged 4 commits into from
Oct 12, 2022
Merged

FIX: AvatarView clipping on Android isn't applied correctly #668

merged 4 commits into from
Oct 12, 2022

Conversation

GeorgeLeithead
Copy link
Contributor

@GeorgeLeithead GeorgeLeithead commented Oct 2, 2022 •
edited by brminnick
Loading

Description of Change

Added clipping offset for all platforms, other than Windows.

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description) : N/A
  • Has samples (if omitted, state reason in description): N/A
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: N/A

Additional information

Tested and verified on platforms -

  • Android
  • Windows
  • Mac Catalyst
  • iOS

This fix must be tested on ALL platforms, as it is an issue for different platforms.

@GeorgeLeithead
Copy link
Contributor Author

I am unable to verify if this bug exists on the iOS or Mac Catalyst platform. As such, I need someone else to verify and if appropriate update the pre-processor directive.

@GeorgeLeithead GeorgeLeithead marked this pull request as draft October 2, 2022 15:22
@GeorgeLeithead GeorgeLeithead marked this pull request as ready for review October 2, 2022 15:23
@GeorgeLeithead GeorgeLeithead marked this pull request as draft October 2, 2022 15:23
@brminnick
Copy link
Collaborator

Thanks George! I tested on iOS + MacCatalyst and everything looks good,

If you are finished working on this PR, please change it from Draft to Ready for Review and we will merge it in 🙌

@GeorgeLeithead
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 668 in repo CommunityToolkit/Maui

@GeorgeLeithead GeorgeLeithead marked this pull request as ready for review October 4, 2022 07:53
@bijington
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brminnick brminnick enabled auto-merge (squash) October 12, 2022 22:12
@brminnick brminnick merged commit e9b0a6c into CommunityToolkit:main Oct 12, 2022
@brminnick brminnick added this to the v1.4.0 milestone Nov 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brminnick brminnick brminnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

[BUG] AvatarView clipping on Android isn't applied correctly
3 participants
@GeorgeLeithead @brminnick @bijington