-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Expander in CollectionView on Apple #751
Conversation
I tried on my end, and that didn't fix for maccatalyst, as you can see in the video below Expander_Workaround.mp4 |
Thank you @pictos. Seems like Task.Delay before InvalidateLayout was not a good solution, that works on all devices. I reworked it. Please check if it works for you |
We merged the change on MAUI |
Thank you @rmarinho! Will it be included in the next release? |
I don't think so, unless we backport the fix to net7 |
@VladislavAntonyuk before moving with this and the other PR that I opened, the fix didn't work well for ListView on maccatalyst |
@pictos the fix is only for CollectionView. I also saw back merge of .NET MAUI to avoid reflection. |
…apped`, Execute `OnHeaderTapped` by default, Throw `NotSupportedException` when `Expander` is used in a `ListView` on iOS + MacCatalyst
src/CommunityToolkit.Maui.UnitTests/Views/Expander/ExpanderTests.cs
Outdated
Show resolved
Hide resolved
117f918
to
c686a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've two suggestions. I just focused on the Expander
related changed
@VladislavAntonyuk Can you update the docs, changing it to " |
This doesn't work if the collection has a header view.
the clickedCell always returns null. |
@AnthonyNjuguna can you please open a new bug issue? |
Description of Change
Set valid size and invalidate layout of CollectionView
Linked Issues
CollectionView
andListView
Support toExpander
#742PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information