Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ToastDuration options documentation with actual duration #793

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

jfversluis
Copy link
Member

While creating a video for Toast I noticed that this enum only specified "short" and "long" which isn't very meaningful to the user. Added the actual length to the description for this.

@jfversluis jfversluis added the ♻ housekeeping This issue/PR is related to internal stuff. label Nov 29, 2022
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keep in mind we'll need to monitor duration of toast with each Android update.

@jfversluis jfversluis merged commit a8a4640 into main Dec 1, 2022
@jfversluis jfversluis deleted the update-ToastDuration-docs branch December 1, 2022 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
♻ housekeeping This issue/PR is related to internal stuff.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants