-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 827 #831
Fix 827 #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaigupta91 thanks for that. I tested the samples and there are some popups that don't show up on the screen. Can you take a look?
@pictos I have fixed that. I have pushed changes. Please check and let me know if i missed something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaigupta91 the MultipleButtonPopup sample still has the issue, as you can see in the screenshot
@pictos It's due to window size. Just increase your window size by dragging Or decrease the size in sample.
|
@pictos Above solution helped to showing popup to you? |
@jaigupta91 I'll take another look during the week, I can't look this weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaigupta91 Thanks for this PR. I made a little change to simplify it a little bit. If you want to test and see if I didn't break anything, let me known, then I'll merge after your review (:
@pictos Thanks for the changes. I tested it and it's working fine. |
With that I'll merge this one before my flight (:. |
Description of Change
Fixed 827 issue
Linked Issues