Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 827 #831

Merged
merged 9 commits into from
Dec 20, 2022
Merged

Fix 827 #831

merged 9 commits into from
Dec 20, 2022

Conversation

jaigupta91
Copy link
Contributor

Description of Change

Fixed 827 issue

Linked Issues

@net-foundation-cla
Copy link

net-foundation-cla bot commented Dec 15, 2022

CLA assistant check
All CLA requirements met.

@pictos pictos self-requested a review December 15, 2022 14:50
@pictos pictos self-assigned this Dec 15, 2022
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaigupta91 thanks for that. I tested the samples and there are some popups that don't show up on the screen. Can you take a look?

@jaigupta91
Copy link
Contributor Author

@pictos I have fixed that. I have pushed changes. Please check and let me know if i missed something.

Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaigupta91 the MultipleButtonPopup sample still has the issue, as you can see in the screenshot

Screenshot 2022-12-16 at 12 18 03

@jaigupta91
Copy link
Contributor Author

jaigupta91 commented Dec 16, 2022

@pictos It's due to window size. Just increase your window size by dragging Or decrease the size in sample.
MultipleButtonPopup.xaml.cs

  • Size = popupSizeConstants.Small; (Changed size from medium to small)

@jaigupta91
Copy link
Contributor Author

@pictos Above solution helped to showing popup to you?

@pictos
Copy link
Member

pictos commented Dec 18, 2022

@jaigupta91 I'll take another look during the week, I can't look this weekend

Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaigupta91 Thanks for this PR. I made a little change to simplify it a little bit. If you want to test and see if I didn't break anything, let me known, then I'll merge after your review (:

@jaigupta91
Copy link
Contributor Author

jaigupta91 commented Dec 20, 2022

@pictos Thanks for the changes. I tested it and it's working fine.

@pictos
Copy link
Member

pictos commented Dec 20, 2022

With that I'll merge this one before my flight (:.
Thanks again❣️

@pictos pictos merged commit 9ee2e54 into CommunityToolkit:main Dec 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The popup is not centered horizontally in the app window on Mac OS
3 participants