[iOS] ShouldAutoPlay=false should not auto play
#954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
changed the title
ShouldAutoPlay=false should not auto play
VladislavAntonyuk
approved these changes
Feb 1, 2023
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds a bit of logic to detect if
ShouldAutoPlayisfalseandSpeedis getting set for the first time. What would happen is:Sourceis getting set which checks if it should start auto playing (which it shouldn't), then we set theSpeedand wheneverSpeedis more than 0, it would still start playing.This should overcome that. I checked Windows and it isn't happening there. That's why I didn't make it a more global solution (because Android already has something similar as well).
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR