Fix crash with unbounded sizing for WrapLayout. #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some new stuff to the sample for easier manipulation.
|
Thanks marcpems for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/WrapLayout/WrapLayout.bind
Outdated
Show resolved
Hide resolved
|
Not sure what the build failure is about... |
|
|
Fixed the Release compile issue |
|
|
||
| _wrapScrollParent = control.FindChildByName("WrapScrollParent") as ScrollViewer; | ||
| var wrapLayoutParent = _wrapScrollParent?.FindDescendant<ItemsRepeater>(); | ||
| _wrapLayout = wrapLayoutParent.Layout as WrapLayout; |
There was a problem hiding this comment.
I hit an exception here, we should already have a reference to the repeater above, testing something out quick.
Kyaa-dost
reviewed
Jun 5, 2020
There was a problem hiding this comment.
It's crashing for me as too. I think @michael-hawker is taking a look. Let's see what seems to be the problem.
skendrot
reviewed
Jun 5, 2020
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/WrapLayout/WrapLayoutPage.xaml.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls.Layout/WrapLayout/WrapLayout.cs
Outdated
Show resolved
Hide resolved
Needed to use Visual helpers here, as apparently Logical ones work differently here in Release mode???
michael-hawker
approved these changes
Jun 6, 2020
delete-merged-branch
bot
deleted the
marcpe/wraplayout_infinite_container_crash
branch
grokys
added a commit
to AvaloniaUI/Avalonia
that referenced
this pull request
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some new stuff to the sample for easier manipulation.
Fixes #3327
#3327
PR Type
What kind of change does this PR introduce?
What is the current behavior?
WrapLayout throws when contained in a control with an infinite size in the axis opposite to the WrapLayout.
What is the new behavior?
It doesnt crash now. And there are some neat controls on the sample to help swap axis.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information