-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generation of nested types that are not classes #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
next preview ✈️
This changes will be available in the upcoming preview
priority 🚩
An issue or change that has priority
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
bugfix 🔧
PRs fixing a discovered bug
labels
Apr 11, 2022
Arlodotexe
reviewed
Apr 11, 2022
Arlodotexe
reviewed
Apr 11, 2022
Arlodotexe
approved these changes
Apr 11, 2022
Sergio0694
force-pushed
the
dev/fix-non-classes-nested-types
branch
from
April 11, 2022 17:10
1f6ee57
to
e698d06
Compare
Nirmal4G
reviewed
Apr 17, 2022
@@ -30,28 +30,26 @@ partial record HierarchyInfo | |||
// Create the partial type declaration with the given member declarations. | |||
// This code produces a class declaration as follows: | |||
// | |||
// partial class <TYPE_NAME> | |||
// partial <TYPE_KIND> TYPE_NAME> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// partial <TYPE_KIND> TYPE_NAME> | |
// partial <TYPE_KIND> <TYPE_NAME> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix 🔧
PRs fixing a discovered bug
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
next preview ✈️
This changes will be available in the upcoming preview
priority 🚩
An issue or change that has priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
PR Checklist