Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of nested types that are not classes #211

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

Sergio0694
Copy link
Member

Closes #210

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels Apr 11, 2022
@Sergio0694 Sergio0694 force-pushed the dev/fix-non-classes-nested-types branch from 1f6ee57 to e698d06 Compare April 11, 2022 17:10
@Sergio0694 Sergio0694 merged commit f003c4f into main Apr 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/fix-non-classes-nested-types branch April 11, 2022 17:28
@@ -30,28 +30,26 @@ partial record HierarchyInfo
// Create the partial type declaration with the given member declarations.
// This code produces a class declaration as follows:
//
// partial class <TYPE_NAME>
// partial <TYPE_KIND> TYPE_NAME>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// partial <TYPE_KIND> TYPE_NAME>
// partial <TYPE_KIND> <TYPE_NAME>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All source generators fail with nested types that are not classes
3 participants