Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct typo in converters #394

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Correct typo in converters #394

merged 2 commits into from
Sep 8, 2022

Conversation

heku
Copy link
Contributor

@heku heku commented Aug 20, 2022

Changes:

  1. Code cleanup
  2. Correct typo to close: Uniform the string format in Converters.ToFileSizeString #393

@heku heku changed the title Correct type in converters Correct typo in converters Aug 20, 2022
@net-foundation-cla
Copy link

net-foundation-cla bot commented Aug 20, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

Nirmal4G
Nirmal4G approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a potential refactor to switch pattern here in the ToFileSizeString method.

dotnet/CommunityToolkit.Common/Converters.cs

Line 17 in 74e24d6

public static string ToFileSizeString(long size)

All in all, LGTM!

Sergio0694
Sergio0694 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 😄

@Sergio0694 Sergio0694 merged commit bb4e41e into CommunityToolkit:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nirmal4G Nirmal4G Nirmal4G approved these changes

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uniform the string format in Converters.ToFileSizeString
3 participants
@heku @Nirmal4G @Sergio0694