Move language diagnostics to diagnostic analyzers #433

Sergio0694 · 2022-09-09T22:11:44Z

Closes #432

PR Checklist

Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
Based off latest main branch of toolkit
PR doesn't include merge commits (always rebase on top of our main, if needed)
Tested code with current supported SDKs
Tests for the changes have been added (for bug fixes / features) (if applicable)
Header has been added to all new source files (run build/UpdateHeaders.bat)
Contains NO breaking changes
Every new API (including internal ones) has full XML docs
Code follows all style conventions

…tion

Sergio0694 added 9 commits September 9, 2022 13:31

Add draft UnsupportedCSharpLanguageVersionAnalyzer

74fc2aa

Check parse options in UnsupportedCSharpLanguageVersionAnalyzer

f9e63fb

Remove FilterWithLanguageVersion method

80625ef

Fix condition in UnsupportedCSharpLanguageVersionAnalyzer

e4ed10b

Add CSharpAnalyzerWithLanguageVersionTest<TAnalyzer> test helper

57055d7

Defer UnsupportedCSharpLanguageVersionAnalyzer symbol action registra…

0a331c1

…tion

Disable IMessenger and ObservableValidator when not on C# 8

408ac01

Don't emit repeated diagnostics for same symbols

3486723

Update generator/analyzer diagnostics unit tests

31745cb

Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Sep 9, 2022

Adjust analyzer diagnostics unit tests to work on all TFMs

f3cbf78

Sergio0694 force-pushed the dev/language-filter-analyzer branch from 60645c7 to f3cbf78 Compare September 9, 2022 23:38

Fix Roslyn 4.0.1 unit test runs in CI script

57832d1

Sergio0694 merged commit 82ccd6c into main Sep 10, 2022

delete-merged-branch bot deleted the dev/language-filter-analyzer branch September 10, 2022 00:04

Sergio0694 mentioned this pull request Apr 11, 2023

MVVM Toolkit Source Generator error Unsupported C# language version #613

Closed

4 tasks