Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use ISymbol in IncrementalValuesProvider<T> nodes #435

Merged
merged 6 commits into from
Sep 10, 2022
Merged

Don't use ISymbol in IncrementalValuesProvider<T> nodes #435

merged 6 commits into from
Sep 10, 2022

Conversation

Sergio0694
Copy link
Member

Closes #425

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Sep 10, 2022
@Sergio0694 Sergio0694 merged commit b3b60f4 into main Sep 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/no-symbols-ivp branch September 10, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use ISymbol in IncrementalValuesProvider<T> nodes
1 participant
@Sergio0694