-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More MVVM Toolkit generator improvements #460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
optimization ☄
Performance or memory usage improvements
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
labels
Sep 30, 2022
Reverting to draft as I want to explore pooling the |
Sergio0694
force-pushed
the
dev/generator-improvements
branch
from
October 4, 2022 16:20
9bef7e6
to
16b34bf
Compare
Sergio0694
force-pushed
the
dev/generator-improvements
branch
from
October 5, 2022 19:50
e0e1fe6
to
0ec0746
Compare
Sergio0694
force-pushed
the
dev/generator-improvements
branch
from
October 5, 2022 19:50
0ec0746
to
66dee36
Compare
Arlodotexe
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
optimization ☄
Performance or memory usage improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few optimizations to the MVVM Toolkit generators:
Result<T>
directly equatableIncrementalValue(s)Provider<T>
and use equatable models directlyDiagnosticInfo
model that doesn't root any compilation itemValidationInfo
not being properly equatableObjectPool<T>
type from RoslynImmutableArrayBuilder<T>
wrapper overObjectPool<T>
ImmutableArrayBuilder<T>
everywhere to reuseImmutableArray<T>.Builder
instancesPR Checklist