Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .NET Core 3.1 TFM #502

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Drop .NET Core 3.1 TFM #502

merged 3 commits into from
Nov 16, 2022

Conversation

Sergio0694
Copy link
Member

This PR includes two changes:

  • Remove the .NET Core 3.1 TFM from the HighPerformance package
  • Switch all unit tests from .NET Core 3.1 to .NET 7

Ie. tests are now on .NET Framework 4.7.2, .NET 6 and .NET 7.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added maintenance ⚙️ Some regular maintenance updates next preview ✈️ This changes will be available in the upcoming preview nuget 📦 Changes or issues related to NuGet publishing high-performance 🚂 Issues/PRs for the HighPerformance package labels Nov 16, 2022
@Sergio0694 Sergio0694 merged commit a3bce08 into main Nov 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/drop-netcoreapp3.1 branch November 16, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-performance 🚂 Issues/PRs for the HighPerformance package maintenance ⚙️ Some regular maintenance updates next preview ✈️ This changes will be available in the upcoming preview nuget 📦 Changes or issues related to NuGet publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant