Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for [ObservableProperty] on _UpperCamel field #551

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

Sergio0694
Copy link
Member

Closes #375

Couldn't repro the issue, but adding a unit test for good measure, since I assume several folks might use this same style.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added testing 🏗️ Issues or changes related to testing infrastructure mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Jan 1, 2023
@Sergio0694 Sergio0694 merged commit 40f7413 into main Jan 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/upper-camel-unit-test branch January 2, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit testing 🏗️ Issues or changes related to testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObservablePropertyAttribute on a field: avoid CS0169?
1 participant