Support partial methods and forwarded attributes with [RelayCommand] #633

Sergio0694 · 2023-03-09T13:14:57Z

Closes #632

cc. @Youssef1313 if you have some spare time 😄

PR Checklist

Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
Based off latest main branch of toolkit
PR doesn't include merge commits (always rebase on top of our main, if needed)
Tested code with current supported SDKs
Tests for the changes have been added (for bug fixes / features) (if applicable)
Header has been added to all new source files (run build/UpdateHeaders.bat)
Contains NO breaking changes
Every new API (including internal ones) has full XML docs
Code follows all style conventions

Also ensure a consistent order for forwarded attributes

src/CommunityToolkit.Mvvm.SourceGenerators/Extensions/MethodDeclarationSyntaxExtensions.cs

Sergio0694 added 2 commits March 9, 2023 13:53

Support partial [RelayCommand] methods

30c4ad4

Fix attributes gathering from partial command methods

a845ad4

Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels Mar 9, 2023

Sergio0694 requested a review from Arlodotexe March 9, 2023 14:04

Sergio0694 added 2 commits March 9, 2023 15:38

Fix partial methods support with Roslyn 4.0

9297335

Also ensure a consistent order for forwarded attributes

Remove unnecessary loop, use list pattern instead

a925b19

Sergio0694 force-pushed the dev/partial-commands branch from c1b5d73 to ada70a0 Compare March 9, 2023 14:38

Youssef1313 reviewed Mar 9, 2023

View reviewed changes

src/CommunityToolkit.Mvvm.SourceGenerators/Extensions/MethodDeclarationSyntaxExtensions.cs Outdated Show resolved Hide resolved

Fix [RelayCommand] attribute over methods with no attributes

66f582b

Sergio0694 force-pushed the dev/partial-commands branch from ada70a0 to 66f582b Compare March 9, 2023 19:26

Sergio0694 merged commit 57d3de4 into main Mar 9, 2023

delete-merged-branch bot deleted the dev/partial-commands branch March 9, 2023 19:47