Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XML docs over generated code #653

Merged
merged 6 commits into from
Mar 25, 2023
Merged

Conversation

Sergio0694
Copy link
Member

This PR adds some more XML docs over generated members by the MVVM Toolkit generators.
Also adds a couple more unit tests while at it.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added documentation 📃 Some proposed change related to documentation improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Mar 25, 2023
@Sergio0694 Sergio0694 merged commit b341ef9 into main Mar 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/generator-xml-docs branch March 25, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📃 Some proposed change related to documentation improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant