Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when using packages.config for MVVM Toolkit #698

Merged
merged 4 commits into from
May 14, 2023

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented May 14, 2023

Closes #695

This PR adds a warning from the imported .targets file if using the MVVM Toolkit via packages.config.
Also adds warning codes and help links to all warnings emitted by the bundled .targets file.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels May 14, 2023
@Sergio0694 Sergio0694 force-pushed the dev/packages-config-warning branch from 42233f6 to 1121201 Compare May 14, 2023 16:30
@Sergio0694 Sergio0694 force-pushed the dev/packages-config-warning branch from 53d4511 to 24b7e8e Compare May 14, 2023 18:21
@Sergio0694 Sergio0694 force-pushed the dev/packages-config-warning branch from 24b7e8e to 14b7672 Compare May 14, 2023 18:47
@Sergio0694 Sergio0694 merged commit fbaf62d into main May 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/packages-config-warning branch May 14, 2023 20:26
Sergio0694 added a commit to Sergio0694/PolySharp that referenced this pull request May 14, 2023
Sergio0694 added a commit to Sergio0694/PolySharp that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ObservableProperty not generated for WPF application targeting .NET Framework 4.8
1 participant