Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The author has previously claimed this results in a massive reduction in memory usage. If it works, It would be great to get it merged. |
|
I suggest to have only the actual changes in the pr and not changes to the style of the code (spaces, tabs, etc), which makes the pr way harder to review. |
Thomas-MMJ
reviewed
Sep 4, 2022
ldm/modules/attention.py
Outdated
| @@ -1,9 +1,10 @@ | |||
| from inspect import isfunction | |||
There was a problem hiding this comment.
please don't include style changes such as import rearrangements or whitespace changes in a commit request
There was a problem hiding this comment.
FYI, you can make git fix some of that automagically. See -> https://github.com/lstein/stable-diffusion/blob/main/.gitattributes
Though, not sure how relevant in this case at second glance. >.>
|
okay I will change it back |
Birch-san
added a commit
to Birch-san/stable-diffusion
that referenced
this pull request
Sep 11, 2022
I didn't implement the most consequential part (splitting the softmax in two) because M1 Mac is not so VRAM-constrained. but I implemented the reference-freeing, and also freed x earlier.
Birch-san
added a commit
to Birch-san/stable-diffusion
that referenced
this pull request
Sep 11, 2022
…CompVis#177 plus some extras from me (del v, del h)
JustinGuese
pushed a commit
to JustinGuese/stable-diffusion-original
that referenced
this pull request
Sep 14, 2022
Bugfixes to image generation logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapted my optimized attention module for original fork