-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api_resource_collector_cluster_role.yaml #519
Conversation
Added permissions for kubedescheduler operator
Hi @ermeratos. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ermeratos, JAORMX The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/hold for test |
Verification passed with 4.17.0-0.nightly-2024-07-07-131215 + #519 code + #11997 code
|
/label qe-approved |
@ermeratos: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We recently fixed an issue with the trivy scan so you may need to rebase to pickup those changes and freshen up the test results. |
@ermeratos could you rebase the PR on top of latest master? |
Hi @yuumasato , I talked to @ermeratos privately. He switched Jobs and employer and does not have any access to this github account anymore. I can offer, that you close this PR and I create a new one and rebase it. |
@sluetze That would be great, thank you. |
Added permissions for kubedescheduler operator