Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce XCCDF #11800

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Reduce XCCDF #11800

merged 2 commits into from
Apr 10, 2024

Conversation

Honny1
Copy link
Collaborator

@Honny1 Honny1 commented Apr 8, 2024

Description:

This PR allows you to reduce the size of XCCDF to normal Datastreams and Thin Datastreams with the specified rule ID. Thin DSs generated by --thin have this feature enabled previously.

The process removes unused CPE platforms, rules, groups, and profiles (In the case of normal Datastream, selects all profiles for the product and uses only the profile with one rule for thin DS.)

When a group is deleted, its children, such as variables, rules, and other subgroups, are also deleted.

Thin DS:

  • Before: 679K
  • After: 114K

Normal Datastream (Product: Fedora):

  • Before: 18,7 MB
  • After: 18,4 MB

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 8, 2024
Copy link

openshift-ci bot commented Apr 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

github-actions bot commented Apr 8, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 8, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11800
This image was built from commit: 5a7ecc9

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11800

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11800 make deploy-local

Copy link

codeclimate bot commented Apr 8, 2024

Code Climate has analyzed commit 5a7ecc9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 11.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Apr 9, 2024
@jan-cerny
Copy link
Collaborator

@Honny1 It would be great if your PR description described which items are removed from the built XML file.

@Honny1
Copy link
Collaborator Author

Honny1 commented Apr 9, 2024

/packit rebuild-failed

@jan-cerny jan-cerny added the Infrastructure Our content build system label Apr 10, 2024
@jan-cerny jan-cerny added this to the 0.1.73 milestone Apr 10, 2024
@jan-cerny
Copy link
Collaborator

I have compared the data stream before and after this change and I have also compared the thin data streams.

@Honny1 Honny1 marked this pull request as ready for review April 10, 2024 10:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 10, 2024
@jan-cerny jan-cerny merged commit 1f6396a into ComplianceAsCode:master Apr 10, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants