Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dconf package name for Ubuntu #11821

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 15, 2024

Description:

In several rules, the OVAL check automatically passes if the dconf package is not present on the system.
On Ubuntu, the rules always pass and give false positives because dconf does not exist.

Fixed by changing the package name to dconf-service.

In several rules, the OVAL check automatically passes if the
`dconf` package is not present on the system.
On Ubuntu, the rules give false positives because `dconf` does not exist.

Fixed to `dconf-service`.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 15, 2024
Copy link

openshift-ci bot commented Apr 15, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11821
This image was built from commit: ac7109a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11821

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11821 make deploy-local

Copy link

codeclimate bot commented Apr 15, 2024

Code Climate has analyzed commit ac7109a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the Ubuntu Ubuntu product related. label Apr 16, 2024
@marcusburghardt marcusburghardt added this to the 0.1.73 milestone Apr 16, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 16, 2024
@dodys dodys self-assigned this Apr 16, 2024
@dodys dodys merged commit 894eb52 into ComplianceAsCode:master Apr 16, 2024
40 of 45 checks passed
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants