-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP-2454: PCI-DSS v4 Requirement 2 #11825
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a few comments and suggestions inline.
These controls are documentation and process specific and there isn't a way to enforce them using the Compliance Operator. Mark them as not applicable.
These controls document and configure usage of system components.
These controls document and process the management of wireless environments including their default settings, paswords and encryption keys. Wireless environments and appliances are specific to each deployment and are not managed by OpenShift.
9e24d4a
to
9c9c71c
Compare
@rhmdnd Thank you for the review. Suggestions implemented or replied to. |
Code Climate has analyzed commit 9c9c71c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label qe-approved |
/lgtm |
Description: