Fix dirs in sysctl template for Ubuntu 20.04/22.04 #11862
Conversation
|
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
mpurg
force-pushed
the
ubuntu_2204_stig_253010
branch
from
86213d8
to
627eeec
Compare
dodys
added
ok-to-test
On Ubuntu /lib is symlinked to /usr/lib, thus /lib/sysctl.d contains package-managed configs, which should not be modified and can be incorrect if overriden elsewhere (see ComplianceAsCode#10637).
mpurg
force-pushed
the
ubuntu_2204_stig_253010
branch
from
627eeec
to
acc14f7
Compare
|
Code Climate has analyzed commit acc14f7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
|
/packit test |
1 similar comment
|
/packit test |
|
/packit build |
|
/packit build |
Description:
/lib/sysctl.das a package-managed directory on Ubuntu.Rationale:
/libis symlinked to/usr/lib, thus/lib/sysctl.dcontains package-managed configs, which should not be modified and can be incorrect if overridden elsewhere (/run,/usr/local,/etc). See Update sysctl template to check(and not fix) /usr/lib/sysctl.d directory #10637