-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crony.d config directory in Ansible in rule chronyd_or_ntpd_set_maxpoll #11958
Merged
marcusburghardt
merged 9 commits into
ComplianceAsCode:master
from
jan-cerny:issue11934
May 28, 2024
Merged
Fix crony.d config directory in Ansible in rule chronyd_or_ntpd_set_maxpoll #11958
marcusburghardt
merged 9 commits into
ComplianceAsCode:master
from
jan-cerny:issue11934
May 28, 2024
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c705bbc - Browse repository at this point
Copy the full SHA c705bbcView commit details -
Fix Ansible in chronyd_or_ntpd_set_maxpoll
The Ansible Tasks in this rule manipulate with many unrelated files such as /etc/sestatus.conf or /etc/krb5.conf. The reason is that they wrongly use the chrony_conf_path variable. They get the name of the parent directory and look for all .conf files there. This probably works nicely for Ubuntu products, where chrony_conf_path is set to /etc/chrony/chrony.conf, but creates harm in all other products where chrony_conf_path is set to /etc/chrony.conf, so the dirname is /etc and the search matches all *.conf files in /etc. We will fix this problem by explicit using the chrony_d_path content variable which defines path to the chrony configuration directory.
Configuration menu - View commit details
-
Copy full SHA for d5f9925 - Browse repository at this point
Copy the full SHA d5f9925View commit details -
Adds scenarios testing the configuration in the .d directory.
Configuration menu - View commit details
-
Copy full SHA for a75fa96 - Browse repository at this point
Copy the full SHA a75fa96View commit details -
Configuration menu - View commit details
-
Copy full SHA for a822992 - Browse repository at this point
Copy the full SHA a822992View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e29659 - Browse repository at this point
Copy the full SHA 9e29659View commit details
Commits on May 10, 2024
-
Update chronyd_or_ntpd_set_maxpoll
- consistent support for the configuration directory - always use product properties `chrony_conf_path` and `chrony_d_path` for the configuration file and configuration directory instead of using hard-coded path - do not pass if no server is set, this align the behavior with RHEL and Ubuntu STIGs
Configuration menu - View commit details
-
Copy full SHA for 37713b8 - Browse repository at this point
Copy the full SHA 37713b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8526b4e - Browse repository at this point
Copy the full SHA 8526b4eView commit details
Commits on May 13, 2024
-
Use the "variables" keyword in the test scenario headers instead of the "profiles" keyword. These test scenarios aren't a regression test special to STIG. The profile was set in order to set the XCCDF Value value. This is legacy usage of the "profiles" keyword and we recommend using "variables" for this situation.
Configuration menu - View commit details
-
Copy full SHA for 24eb0c3 - Browse repository at this point
Copy the full SHA 24eb0c3View commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec9c0f7 - Browse repository at this point
Copy the full SHA ec9c0f7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.