Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crony.d config directory in Ansible in rule chronyd_or_ntpd_set_maxpoll #11958

Merged
merged 9 commits into from
May 28, 2024

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    c705bbc View commit details
    Browse the repository at this point in the history
  2. Fix Ansible in chronyd_or_ntpd_set_maxpoll

    The Ansible Tasks in this rule manipulate with many unrelated files such
    as /etc/sestatus.conf or /etc/krb5.conf.  The reason is that they
    wrongly use the chrony_conf_path variable. They get the name of the
    parent directory and look for all .conf files there. This probably works
    nicely for Ubuntu products, where chrony_conf_path is set to
    /etc/chrony/chrony.conf, but creates harm in all other products where
    chrony_conf_path is set to /etc/chrony.conf, so the dirname is /etc and
    the search matches all *.conf files in /etc.
    
    We will fix this problem by explicit using the chrony_d_path content
    variable which defines path to the chrony configuration directory.
    jan-cerny committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d5f9925 View commit details
    Browse the repository at this point in the history
  3. Add new test scenarios

    Adds scenarios testing the configuration in the .d directory.
    jan-cerny committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a75fa96 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a822992 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e29659 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Update chronyd_or_ntpd_set_maxpoll

    - consistent support for the configuration directory
    - always use product properties `chrony_conf_path` and `chrony_d_path`
      for the configuration file and configuration directory instead of
      using hard-coded path
    - do not pass if no server is set, this align the behavior with RHEL
      and Ubuntu STIGs
    jan-cerny committed May 10, 2024
    Configuration menu
    Copy the full SHA
    37713b8 View commit details
    Browse the repository at this point in the history
  2. Fix ShellCheck problems

    jan-cerny committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8526b4e View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Update test scenarios headers

    Use the "variables" keyword in the test scenario headers instead of the
    "profiles" keyword. These test scenarios aren't a regression test
    special to STIG. The profile was set in order to set the XCCDF Value
    value. This is legacy usage of the "profiles" keyword and we recommend
    using "variables" for this situation.
    jan-cerny committed May 13, 2024
    Configuration menu
    Copy the full SHA
    24eb0c3 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Configuration menu
    Copy the full SHA
    ec9c0f7 View commit details
    Browse the repository at this point in the history