Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rule package_pam_pwquality_installed to Ubuntu 22.04 CIS profile #11968

Merged

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented May 8, 2024

Description:

  • Add missing rule package_pam_pwquality_installed to Ubuntu 22.04 CIS profile

Rationale:

@mpurg mpurg requested a review from a team as a code owner May 8, 2024 07:00
Copy link

openshift-ci bot commented May 8, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 8, 2024
@mpurg mpurg changed the title Add missing rule package_pam_pwquality to Ubuntu 22.04 CIS profile Add missing rule package_pam_pwquality_installed to Ubuntu 22.04 CIS profile May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this May 8, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. labels May 8, 2024
Copy link

github-actions bot commented May 8, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11968
This image was built from commit: 800cff5

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11968

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11968 make deploy-local

Copy link

codeclimate bot commented May 8, 2024

Code Climate has analyzed commit 800cff5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 3fcbe22 into ComplianceAsCode:master May 8, 2024
108 checks passed
@Mab879 Mab879 added this to the 0.1.74 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants