-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dconf_gdm_dir on OL9 #12040
Fix dconf_gdm_dir on OL9 #12040
Conversation
It is causing the nightly builds to fail
@Xeicker is this expected? |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting it. I recently merged the PR that did this change on main product file, but didn't update this stability file.
How should've I spotted that issue? I didn't know this stability file existed
Code Climate has analyzed commit 2ff2651 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
Thanks for the quick approval. It should have been been spotted in CI. But it appears that many products where not tested in CI . I made #12041 and that should fix the issue. |
/retest-required |
/packit test |
Description:
Fix dconf_gdm_dir in the stable products files on OL9.
Rationale:
It is causing the nightly builds to fail.