Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dconf_gdm_dir on OL9 #12040

Merged
merged 1 commit into from
May 31, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented May 30, 2024

Description:

Fix dconf_gdm_dir in the stable products files on OL9.

Rationale:

It is causing the nightly builds to fail.

It is causing the nightly builds to fail
@Mab879 Mab879 added bugfix Fixes to reported bugs. Oracle Linux Oracle Linux product related. labels May 30, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone May 30, 2024
@Mab879 Mab879 requested a review from a team as a code owner May 30, 2024 19:17
@Mab879
Copy link
Member Author

Mab879 commented May 30, 2024

@Xeicker is this expected?

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12040
This image was built from commit: 2ff2651

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12040

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12040 make deploy-local

Copy link
Contributor

@Xeicker Xeicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it. I recently merged the PR that did this change on main product file, but didn't update this stability file.

How should've I spotted that issue? I didn't know this stability file existed

Copy link

codeclimate bot commented May 30, 2024

Code Climate has analyzed commit 2ff2651 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 mentioned this pull request May 30, 2024
@Mab879
Copy link
Member Author

Mab879 commented May 30, 2024

Thanks for spotting it. I recently merged the PR that did this change on main product file, but didn't update this stability file.

How should've I spotted that issue? I didn't know this stability file existed

Thanks for the quick approval.

It should have been been spotted in CI. But it appears that many products where not tested in CI . I made #12041 and that should fix the issue.

@Mab879
Copy link
Member Author

Mab879 commented May 30, 2024

/retest-required

@marcusburghardt
Copy link
Member

/packit test

@Xeicker Xeicker merged commit d070c76 into ComplianceAsCode:master May 31, 2024
112 of 113 checks passed
@Mab879 Mab879 deleted the fix_nightly_2024_05_30 branch June 3, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. Oracle Linux Oracle Linux product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants