-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify ubuntu remediation for dconf_gnome_banner_enabled #12042
Modify ubuntu remediation for dconf_gnome_banner_enabled #12042
Conversation
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
2d1ddde
to
94421da
Compare
/packit build |
fcea6b2
to
e4bd034
Compare
/packit build |
The remediation was modified to enable the banner also in `greeter.dconf-defaults` and not only in the dconf database. This is to be consistent with the remediation in related rule `dconf_gnome_login_banner_text` and be better aligned with STIG V1R1.
e4bd034
to
09639ea
Compare
Code Climate has analyzed commit 09639ea and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
greeter.dconf-defaults
and not only in the dconf database.Rationale:
dconf_gnome_login_banner_text
and be better aligned with STIG V1R1.