Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule file_permissions_backup_etc_shadow for SLE15/SLE12 #12047

Conversation

svet-se
Copy link
Contributor

@svet-se svet-se commented Jun 5, 2024

Description:

  • Fix target permissions on /etc/shadow- for SLE15/SLE12

Rationale:

  • According to CIS SLE 15 Benchmark v1.1.1 and CIS SLE 12 Benchmark v3.1.0 "verify /etc/shadow- access is 0640 or more restrictive"

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 5, 2024
Copy link

openshift-ci bot commented Jun 5, 2024

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jun 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 5, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12047
This image was built from commit: 4063a8b

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12047

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12047 make deploy-local

@marcusburghardt marcusburghardt added the SLES SUSE Linux Enterprise Server product related. label Jun 6, 2024
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 🙇

Copy link

codeclimate bot commented Jun 10, 2024

Code Climate has analyzed commit 4063a8b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair merged commit 1c83564 into ComplianceAsCode:master Jun 10, 2024
104 of 106 checks passed
@Mab879 Mab879 added this to the 0.1.74 milestone Jun 10, 2024
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants