Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 22.04 Automatus workflow #12058

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Add Ubuntu 22.04 Automatus workflow

Rationale:

  • Add this workflow so that we can build and test content on Ubuntu 22.04

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 12, 2024
Copy link

openshift-ci bot commented Jun 12, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 12, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12058
This image was built from commit: 38be00d

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12058

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12058 make deploy-local

@dodys dodys added the Ubuntu Ubuntu product related. label Jun 12, 2024
@dodys
Copy link
Contributor

dodys commented Jun 12, 2024

@marcusburghardt @Mab879 would it be ok to add the automatus workflow for ubuntu? And could you verify it is in order like the rest?

@Mab879 Mab879 self-assigned this Jun 12, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jun 12, 2024
@Mab879 Mab879 added the Test Suite Update in Test Suite. label Jun 12, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I found a few things that need some attention.

.github/workflows/automatus-ubuntu2204.yaml Outdated Show resolved Hide resolved
.github/workflows/automatus-ubuntu2204.yaml Outdated Show resolved Hide resolved
.github/workflows/automatus-ubuntu2204.yaml Outdated Show resolved Hide resolved
@dodys dodys requested a review from Mab879 June 18, 2024 09:44
Copy link

codeclimate bot commented Jun 18, 2024

Code Climate has analyzed commit 38be00d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks.

@Mab879 Mab879 merged commit dbd791b into ComplianceAsCode:master Jun 18, 2024
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants