Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependency "xmllint" package #12080

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Fix the "Could not find XMLLINT_EXECUTABLE" error

Rationale:

  • Use apt to install the required dependency xmllint from libxml2-utils

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 19, 2024
Copy link

openshift-ci bot commented Jun 19, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12080
This image was built from commit: ae8a511

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12080

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12080 make deploy-local

Copy link

codeclimate bot commented Jun 19, 2024

Code Climate has analyzed commit ae8a511 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jun 20, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen that the libxml2-utils have successfully installed in the Ubuntu 22.04 CI job. Unfortunately, the build didn't happen because it's filtered out by CTF.

The CI fail on Fedora Rawhide is a problem in dnf and isn't caused by the contents of this PR.

@jan-cerny jan-cerny merged commit bb972b3 into ComplianceAsCode:master Jun 20, 2024
87 of 88 checks passed
@jan-cerny jan-cerny added this to the 0.1.74 milestone Jun 20, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Jun 20, 2024
@alanmcanonical alanmcanonical deleted the ubuntu_workflow branch August 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants