Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filename for UBI test #12115

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 2, 2024

Description:

I introduced a minor bug in the Automatus UBI8 test in #12100, this should fix that.

Rationale:

So the tests work.

Review Hints:

  • Review the CI and ensure that "Automatus UBI8" passes.
  • Once approved I will remove the example commit trigger the CI.

@Mab879 Mab879 added the Infrastructure Our content build system label Jul 2, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 2, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 2, 2024
Copy link

openshift-ci bot commented Jul 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

github-actions bot commented Jul 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 2, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12115
This image was built from commit: 6aad455

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12115

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12115 make deploy-local

@Mab879 Mab879 marked this pull request as ready for review July 2, 2024 15:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 2, 2024
@jan-cerny jan-cerny self-assigned this Jul 4, 2024
@jan-cerny
Copy link
Collaborator

@Mab879 the UBI8 job runs and doesn't fail but the rule is evaluated as "notapplicable", is that expected?

@Mab879
Copy link
Member Author

Mab879 commented Jul 8, 2024

/packit reset-failed

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a comment, would it be interesting to also rename the automatus-cs8.yaml file to automatus-ubi8.yaml?

@jan-cerny
Copy link
Collaborator

/packit build

@Mab879
Copy link
Member Author

Mab879 commented Jul 10, 2024

@Mab879 the UBI8 job runs and doesn't fail but the rule is evaluated as "notapplicable", is that expected?

Due to the reduced package set in UBI 8, that seems to be expected.

[root@c47f06594a31 /]# dnf install tmux
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Last metadata expiration check: 0:02:55 ago on Wed Jul 10 09:34:06 2024.
No match for argument: tmux
Error: Unable to find a match: tmux

@Mab879
Copy link
Member Author

Mab879 commented Jul 10, 2024

LGTM. Just a comment, would it be interesting to also rename the automatus-cs8.yaml file to automatus-ubi8.yaml?

So moved.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please remove the example test scenario now.

@Mab879
Copy link
Member Author

Mab879 commented Jul 11, 2024

LGTM.

Please remove the example test scenario now.

Done

Copy link

codeclimate bot commented Jul 11, 2024

Code Climate has analyzed commit 6aad455 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

/packit build

@jan-cerny jan-cerny merged commit 1fdade9 into ComplianceAsCode:master Jul 16, 2024
93 of 94 checks passed
@Mab879 Mab879 deleted the fix_ubi8_test branch July 16, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants